[JTT-291] - Relaxation of the PV limits #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidations and added tests to it
shalinnijel2
suggested changes
Nov 1, 2023
shalinnijel2
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are EVs that surpass the initial limitations imposed by DIN70121 and ISO 15118-2 to the Physical Values, it is important to provide a way to disable the validation, thus it was added a new config variable to enforce relaxation of the PV limits validations, calledIGNORE_PHYSICAL_VALUES_LIMITSin settings.pyEDIT: After an internal discussion, it was decided to remove the validations as in practice they are just a blocker for implementers. If later we come to the conclusion that some validations are necessary, those can be added case by case.