Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JTT-112 Feat: Enable mypy support #294

Merged
merged 26 commits into from
Sep 12, 2023
Merged

JTT-112 Feat: Enable mypy support #294

merged 26 commits into from
Sep 12, 2023

Conversation

santiagosalamandri
Copy link
Contributor

This PR includes:

  • Resolution of all mypy, black, isort, and flake-related issues.
  • Mypy enabled in code-quality checks.
  • Integration of Mypy into the GitHub Actions workflow for automated checks.

Validation
Testing was carried out on the SECC/EVCC simulator, resulting in a clean execution with no issues, warnings, or exceptions. for the following protocols/modes:

Protocol Status
DIN PASS
-2 ac eim PASS
-2 dc eim PASS
-2 ac pnc PASS
-2 dc pnc PASS
-20 ac PASS
-20 dc PASS
-20 ac-bpt PASS
-20 dc-bpt PASS

@notion-workspace
Copy link

JTT-112 ISO15118 - MyPy support

@santiagosalamandri santiagosalamandri marked this pull request as ready for review September 7, 2023 10:43
shalinnijel2
shalinnijel2 suggested changes Sep 8, 2023
View reviewed changes
iso15118/shared/utils.py Outdated Show resolved Hide resolved
shalinnijel2
shalinnijel2 suggested changes Sep 8, 2023
View reviewed changes
iso15118/shared/states.py Outdated Show resolved Hide resolved
iso15118/shared/comm_session.py Outdated Show resolved Hide resolved
shalinnijel2
shalinnijel2 suggested changes Sep 8, 2023
View reviewed changes
iso15118/shared/security.py Outdated Show resolved Hide resolved
@santiagosalamandri santiagosalamandri merged commit b551833 into master Sep 12, 2023
@mdwcrft mdwcrft mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinnijel2 shalinnijel2 shalinnijel2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santiagosalamandri @shalinnijel2