Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduleExchange(StateEVCC_bug) #292

Merged

Conversation

GUANMINLIAO
Copy link
Contributor

Dear Authors:
I change class ScheduleExchange(StateEVCC)

   if self.comm_session.selected_energy_service in (
            ServiceV20.AC_BPT,
            ServiceV20.DC_BPT,
        ):
        
   to
   
   if self.comm_session.selected_energy_service.service in (
          ServiceV20.AC_BPT,
          ServiceV20.DC_BPT,
      ):

Otherwise, ChannelSelection.DISCHARGE or ChannelSelection.CHARGE cannot be determined.

Many thanks,
Mike

@tropxy tropxy requested a review from shalinnijel2 August 20, 2023 15:16
@shalinnijel2 shalinnijel2 force-pushed the class_ScheduleExchange_StateEVCC_bug branch from c7e1bd1 to 3f45cb2 Compare August 22, 2023 08:16
Copy link
Contributor

@shalinnijel2 shalinnijel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved the PR as the fix is required to add the bpt_channel information in PowerDeliveryReq. However, I'm not still not very clear on how the information will be used.
This is what I see in the spec:

[V2G20-2123] If the BPT service was selected in either AC or DC and the reverse power transfer system requires HLC-based control of switching electricity power channels, the parameter BPT_ChannelSelection of PowerDeliveryReq shall be applied.

@shalinnijel2 shalinnijel2 merged commit e9bc4e2 into EcoG-io:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants