Fix/set present #159
Merged
Fix/set present #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ikaratass
commented
Nov 10, 2022
ikaratass
commented
- set_present_protocol_state method is awaitable.
iso15118/shared/comm_session.py
Outdated
| if hasattr(self.comm_session, "evse_controller"): | ||
| await self.comm_session.evse_controller.set_present_protocol_state( | ||
| str(self.current_state) | ||
| ) | ||
| # This will create the values needed for the next state, such as | ||
| # next_state, next_v2gtp_message, next_message_payload_type etc. | ||
| await self.process_message(message) |
There was a problem hiding this comment.
Looks like it might suffice to call set_present_protocol_state once after the above self.process_message?
if hasattr(self.comm_session, "evse_controller"):
await self.comm_session.evse_controller.set_present_protocol_state(
# noqa
str(self.current_state)
)
shalinnijel2
suggested changes
Nov 11, 2022
iso15118/shared/comm_session.py
Outdated
Comment on lines
492
to
495
| if hasattr(self.comm_session, "evse_controller"): | ||
| await self.comm_session.evse_controller.set_present_protocol_state( # noqa | ||
| str(self.current_state.next_state.__name__) | ||
| ) |
There was a problem hiding this comment.
This could be removed as discussed.
shalinnijel2
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.