the EVAP variable is always zero in BMI

[MostafaGomaa93]

The Èvap variable is always zero through BMI, although it has a value. I checked that if we delete the all_timesteps = True in this line, the Èvap variable will get its value in BMI

[BSchilperoort]

The all_timesteps variable denotes if the variable is an array which contains data on all time steps. This bug probably crept in because EVAP is an array of size n_timesteps, but only the first index is used to put any value in.

Can you check this and open an issue in STEMMUS_SCOPE? This could lead to incorrect results if sometimes it's used as EVAP[index_time] = x and sometimes EVAP[0] = x...

[SarahAlidoost]

@MostafaGomaa93 Note that there are two variables EVAP and Evap 😄 . The line you mentioned is related to EVAP and not Evap. These two variables have a similar problem to variable Trap, see this comment. Can you also fix the code to have one variable for evapotranspiration?

[MostafaGomaa93]

@MostafaGomaa93 Note that there are two variables EVAP and Evap 😄 . The line you mentioned is related to EVAP and not Evap. These two variables have a similar problem to variable Trap, see this comment. Can you also fix the code to have one variable for evapotranspiration?

Okay, I removed EVAP and adjusted Evap in this PR