Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary extra evaporation variable #274

Closed
MostafaGomaa93 opened this issue Dec 10, 2024 · 0 comments · Fixed by #273
Closed

Unnecessary extra evaporation variable #274

MostafaGomaa93 opened this issue Dec 10, 2024 · 0 comments · Fixed by #273

Comments

@MostafaGomaa93
Copy link
Contributor

The code has variables for evaporation (Evap and EVAP). They are exactly the same. Additionally, the array size of both is not compatible with BMI requirements as been discussed in this issue

Solution:

  • The EVAP variable is removed and only Evap is kept
  • The size of Evap array is changed to 1D array
    The changes are done in PR 273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redefine Evap and Trap arrays EcoExtreML/STEMMUS_SCOPE
1 participant
@MostafaGomaa93