Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a license file #153

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add a license file #153

merged 1 commit into from
Apr 5, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Apr 4, 2023 •
edited
Loading

Description

closes #152

relates #2

Update executable file

Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • Documentation is available.
  • Model runs successfully.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review April 5, 2023 10:25
BSchilperoort
BSchilperoort approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see the license being detected yet by github, but I guess it's because it is not on the main branch. The filename, location and content all seem fine if I compare it to others.

@SarahAlidoost SarahAlidoost merged commit 5d4c2f9 into main Apr 5, 2023
@SarahAlidoost SarahAlidoost deleted the add_license branch April 5, 2023 12:48
@BSchilperoort BSchilperoort mentioned this pull request Jun 21, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the repo public
2 participants
@SarahAlidoost @BSchilperoort