Change filesread to a function io/prepareforcing #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahAlidoost
requested changes
Aug 8, 2022
There was a problem hiding this comment.
@Crystal-szj thanks 👍 please see my comments and let me know if something is not clear.
Thanks, Sarah, for your comments and suggestions. I've revised them according to your advice. |
SarahAlidoost
requested changes
Aug 10, 2022
There was a problem hiding this comment.
@Crystal-szj thanks for the fixes. Just some small comments to make the code better.
Co-authored-by: SarahAlidoost <[email protected]>
Co-authored-by: SarahAlidoost <[email protected]>
Co-authored-by: SarahAlidoost <[email protected]>
SarahAlidoost
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #86 We refactored filesread to a function.
Notes: there are still global variables in the main script, but other functions has to change to fix the global issue.