Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a two-hot encoding function #45

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Conversation

DavideTr8
Copy link
Collaborator

Summary

Describe the purpose of the pull request, including:

A function for converting tensors representing floating point to a two-hot representation, as done in MuZero and Dreamer V3 papers.

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Copy link
Member

@belerico belerico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the implementation in the Dreamer-V3 paper is more general than this one (https://arxiv.org/abs/2301.04104). Could we adjust it?

belerico
belerico previously approved these changes Jul 5, 2023
@belerico belerico self-requested a review March 30, 2024 11:07
@DavideTr8 DavideTr8 merged commit b8afd8a into main Mar 30, 2024
10 checks passed
@belerico belerico deleted the feature/two_hot_encoder branch March 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants