-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/memory error sampling #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belerico
requested review from
DavideTr8,
michele-milesi and
rcmalli
as code owners
May 5, 2024 17:50
This was
linked to
issues
May 5, 2024
Closed
… feature/memory-error-sampling
… feature/memory-error-sampling
michele-milesi
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we have fixed multiple problems related to the resuming from checkpoint functionality. In particular:
algo.learning_starts
was read from the old config and if the buffer was not saved into the checkpoint then at the first training iteration theRatio
class, to keep with the replay-ratio after thealgo.learning_starts
steps, will output a huge number of per_rank_gradient_steps to be run on the first training iteration which could lead to OOM or to really slow training timealgo.learning_starts
even when resuming from a checkpoint. Setalgo.learning_starts=0
to disable the buffer pre-fillalgo.learning_starts
are not taken into consideration for the replay-ratio computation also when resuming from checkpointType of Change
Please select the one relevant option below:
Checklist
Please confirm that the following tasks have been completed:
Screenshots or Visuals (Optional)
If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.
Additional Information (Optional)
Please provide any additional information that may be useful for the reviewer, such as:
Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.