Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/player build agent #258

Merged
merged 86 commits into from
Apr 8, 2024
Merged

Fix/player build agent #258

merged 86 commits into from
Apr 8, 2024

Conversation

belerico
Copy link
Member

@belerico belerico commented Apr 5, 2024

Summary

This PR moves the creation of the player agent inside the build_agent method. Furthermore:

  • Players are deep-copy of the train agents, but with tied weights
  • Every model in the player is setup with a single-device Fabric, i.e. a Fabric object that shares the same precision and accelerator as the main one, but with a single-device strategy to prevent synchronization points during the environment interaction
  • Every build_agent method returns the player agent
  • Every player agent defines a forward and get_actions methods, plus auxiliary ones

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Screenshots or Visuals (Optional)

If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.

Additional Information (Optional)

Please provide any additional information that may be useful for the reviewer, such as:

  • Any potential risks or challenges associated with the changes.
  • Any instructions for testing or running the code.
  • Any other relevant information.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

belerico and others added 30 commits February 8, 2024 09:07
@belerico belerico force-pushed the fix/player-build-agent branch from ac74c1d to 7711d19 Compare April 8, 2024 08:05
@belerico belerico merged commit 32a3736 into main Apr 8, 2024
10 checks passed
@belerico belerico deleted the fix/player-build-agent branch April 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants