-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/player build agent #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/dv3-parallel-stochastic
… feature/dv3-parallel-stochastic
… feature/dv3-replay-ratio
… feature/dv3-replay-ratio
…eep/sheeprl into feature/replay-ratio
… fix/player-build-agent
…p/sheeprl into fix/player-build-agent
…/Eclectic-Sheep/sheeprl into fix/player-build-agent
…/Eclectic-Sheep/sheeprl into fix/player-build-agent
… fix/player-build-agent
belerico
requested review from
DavideTr8,
michele-milesi and
rcmalli
as code owners
April 5, 2024 14:08
belerico
force-pushed
the
fix/player-build-agent
branch
from
April 8, 2024 08:05
ac74c1d
to
7711d19
Compare
michele-milesi
approved these changes
Apr 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the creation of the player agent inside the
build_agent
method. Furthermore:single-device
Fabric, i.e. a Fabric object that shares the same precision and accelerator as the main one, but with a single-device strategy to prevent synchronization points during the environment interactionbuild_agent
method returns the player agentforward
andget_actions
methods, plus auxiliary onesType of Change
Please select the one relevant option below:
Checklist
Please confirm that the following tasks have been completed:
Screenshots or Visuals (Optional)
If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.
Additional Information (Optional)
Please provide any additional information that may be useful for the reviewer, such as:
Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.