Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dreamer v3 #253

Merged
merged 62 commits into from
Apr 3, 2024
Merged

Fix/dreamer v3 #253

merged 62 commits into from
Apr 3, 2024

Conversation

michele-milesi
Copy link
Member

@michele-milesi michele-milesi commented Apr 3, 2024

Summary

Describe the purpose of the pull request, including:

  • Added LayerNormFP32 and LayerNormChannelLastFP32 for computing the layer norm always in full precision.
  • Added possibility to select, for each model, which layer norm to use in Dreamer V3
  • Added possibility to specify the kwargs of the LN layers for each model in Dv3
  • Added learnable initial recurrent state in dv3
  • Moments in dv3 are always computed in full precision
  • Fixed env interaction in dreamer and p2e algorithms

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Screenshots or Visuals (Optional)

If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.
ww-final
The reward obtained by DreamerV3 in the Walker Walk environment from DMC with the modifications described above.

belerico and others added 30 commits February 8, 2024 09:07
@belerico belerico merged commit 0da0194 into main Apr 3, 2024
10 checks passed
@belerico belerico deleted the fix/dreamer_v3 branch April 3, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants