Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for python 3.8 #243

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix CI for python 3.8 #243

merged 2 commits into from
Mar 27, 2024

Conversation

belerico
Copy link
Member

Summary

This PR solves an issue raised by our CI:

def is_config(self, config_path: str) -> bool:
        config_path = self._normalize_file_name(config_path)
        try:
            files = resources.files(self.path)
        except (ValueError, ModuleNotFoundError, TypeError):
            return False
        res = files.joinpath(config_path)
>       ret = res.exists() and res.is_file()
E       AttributeError: 'OrphanPath' object has no attribute 'exists'

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico changed the base branch from fix/player-precision-plugin to main March 27, 2024 12:39
@belerico belerico merged commit 939d30d into main Mar 27, 2024
10 checks passed
@belerico belerico deleted the fix/ci-orphan-path branch March 27, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants