Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/determinism #231

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix/determinism #231

merged 3 commits into from
Mar 12, 2024

Conversation

belerico
Copy link
Member

Summary

This PR fixes #228 by adding all the PyTorch flags to run deterministic experiments given the same hardware. Deterministic runs are not achievable on different hardware, as explained here.

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit afee2cd into main Mar 12, 2024
10 checks passed
@belerico belerico deleted the fix/determinism branch March 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to repro dreamer_v3_100k_ms_pacman experiment reward results
2 participants