Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory mapping on Windows #193

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix memory mapping on Windows #193

merged 2 commits into from
Jan 19, 2024

Conversation

belerico
Copy link
Member

Summary

This PR fixes #188, in particular it prevents the automatic deletion of checkpoints by the OS under Windows

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 5163fd1 into main Jan 19, 2024
10 checks passed
@belerico belerico deleted the fix/windows-memmap branch February 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Checkpointing the buffer
2 participants