Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bugs #181

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Fix/bugs #181

merged 4 commits into from
Jan 4, 2024

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Fix bugs:
    • when bootstrapping in ppo, only the reward of the truncated environment must be bootstrapped
    • Fixed timer in PPO decoupled and SAC decoupled
    • Fixed minedojo _convert_action function (when resetting the sticky attack counter)
    • Fixed ppo recurrent configs

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@michele-milesi michele-milesi linked an issue Jan 4, 2024 that may be closed by this pull request
Copy link
Member

@belerico belerico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤟

@michele-milesi michele-milesi merged commit 038facd into main Jan 4, 2024
10 checks passed
@michele-milesi michele-milesi deleted the fix/bugs branch January 5, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the in sticky attack in MineDojo wrapper
2 participants