Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimizations #177

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Feature/optimizations #177

merged 3 commits into from
Dec 22, 2023

Conversation

belerico
Copy link
Member

Summary

In this PR we have added some optimizations, in particular:

  • The creation of the metric on the timer object is not needed when the timer is disabled
  • In the MultiEncoder class the concatenation of empty tensors with dense ones has been removed
  • We now let the user decide if he/she wants to run the test at the end of the training, true by default

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 955a57f into main Dec 22, 2023
10 checks passed
@belerico belerico deleted the feature/optimizations branch January 4, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants