Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added optimizations #168

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat: added optimizations #168

merged 4 commits into from
Dec 13, 2023

Conversation

michele-milesi
Copy link
Member

@michele-milesi michele-milesi commented Dec 12, 2023

Summary

Describe the purpose of the pull request, including:

  • Added full_like(), zeros_like() and ones_like() where needed.
  • Moved logging after training.
  • Converted TensorDicts into python dictionary before training.
  • Add _convert_="all" during the creation of the metric aggregator.
  • Modified log_prob() method of TwoHotEncodingDistribution
  • Removed distribution creation when not necessary in DreamerV1 and DreamerV2

Type of Change

Please select the one relevant option below:

  • Optimization (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@michele-milesi michele-milesi linked an issue Dec 12, 2023 that may be closed by this pull request
@belerico belerico merged commit 796cd96 into main Dec 13, 2023
10 checks passed
@michele-milesi michele-milesi deleted the feature/optimizations branch December 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some distribution creation doesn' t do anything
2 participants