Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/algos #120

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Fix/algos #120

merged 3 commits into from
Oct 10, 2023

Conversation

belerico
Copy link
Member

Summary

In this PR we have fixed multiple minor bugs, i.e.:

  • Reshape the image observations when bootstrapping in all the PPO algorithms
  • The image normalization is carried out by / 255.0 - 0.5 in all the PPO algorithms
  • Prevent saving the "observations" keys in P2E-DV1
  • Fix metrics when they are nan
  • Log timer metrics only if times have been measured

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 48b8807 into main Oct 10, 2023
@belerico belerico deleted the fix/algos branch October 10, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants