Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(check-urls): fix push crash on new branch creation + render awesome_bot report #7046

Merged
merged 12 commits into from
Aug 31, 2022

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Aug 28, 2022

What does this PR do?

Improve repo

Description

I'm improving check-url workflow. At this moment, I've:

Fixed a wellknown crash 505592e

... fixed the crash when push event is fired the first time on a new branch. I've just change the used action (not mantained since 2020) by other one: tj-actions/changed-files.

Also is faster since is written in bash and doesn't need Node interpreter to be runned.

AwesomeBot run report 3d0c109

... added a final step to generate a report summary for the action viewable from their run details. Some outputs:

With no issues Having issues
See Output See Output
With no issues Having link issues

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. 🤖 automation Automated tasks done by workflows or bots labels Aug 28, 2022
@davorpa davorpa self-assigned this Aug 28, 2022
@davorpa davorpa marked this pull request as ready for review August 28, 2022 15:53
@eshellman
Copy link
Collaborator

maybe @sashashura can review

@sashashura
Copy link
Contributor

Permissions look good to me. It seems tj-actions/changed-files doesn't need any additional permissions except content read. It is a bit of trial and error since I'm not aware of a way to test it locally. If it fails when merged try adding pull-requests: read, but I think it is not needed. Just ping me and I'll take a look. Happy to help.

@davorpa davorpa marked this pull request as draft August 29, 2022 10:57
@davorpa davorpa added the conflicts Conflict(s) need to be resolved label Aug 29, 2022
@davorpa

This comment was marked as outdated.

@davorpa davorpa removed the conflicts Conflict(s) need to be resolved label Aug 29, 2022
@davorpa davorpa marked this pull request as ready for review August 29, 2022 16:42
@eshellman
Copy link
Collaborator

ready to merge?

@davorpa
Copy link
Member Author

davorpa commented Aug 30, 2022

ready to merge?

Sure! no more commits

@eshellman eshellman merged commit 57cc317 into EbookFoundation:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automation Automated tasks done by workflows or bots urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants