Add Java 21 in the CI build #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justintime50
previously approved these changes
Nov 29, 2023
Justintime50
approved these changes
Nov 29, 2023
|
question: why do we have lombok defined twice in |
That one is for error-prone specifically since Lombok will auto-generate the setter/getter methods for you, removing it will cause the build to fail because error-prone will throw errors indicating getter/setter methods are not found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add java 21 in the CI build
Bump lombok to support JDK 21
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.