Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrates v4 changes to master #348

Closed
wants to merge 1 commit into from
Closed

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Oct 3, 2022

Description

Migrates all the v4 changes from its branch to master. We blew away every file and replaced it with the contents of the v4 branch to avoid the hundreds of merge conflicts. The v4 branch should include everything needed moving forward so this change should be safe to make.

Testing

Pray CI passes...

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50
Copy link
Member Author

Closing this in favor of #349 so we can keep the commit history.

@nwithan8 nwithan8 deleted the migrate_v4 branch October 4, 2022 23:08
@nwithan8 nwithan8 restored the migrate_v4 branch October 4, 2022 23:08
@nwithan8 nwithan8 deleted the migrate_v4 branch October 4, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant