Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down model constructors #340

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Lock down model constructors #340

merged 1 commit into from
Sep 26, 2022

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Sep 23, 2022

Description

  • Mark constructors for all models as "internal" to prevent end-users from making instances directly
    • var address = new Address() \\ bad
    • var address = await myClient.Address.Retrieve() \\ good
  • Update unit tests for F# and VB to account for redesign

Testing

  • All unit tests pass

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

… making instances directly

- Update unit tests for F# and VB to account for redesign
@nwithan8 nwithan8 requested a review from a team September 23, 2022 22:28
@nwithan8 nwithan8 merged commit 5a26505 into v4 Sep 26, 2022
@nwithan8 nwithan8 deleted the model_constructors branch September 26, 2022 17:03
@Justintime50 Justintime50 mentioned this pull request Oct 3, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants