Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4 Upgrade Guide #337

Merged
merged 2 commits into from
Sep 23, 2022
Merged

v4 Upgrade Guide #337

merged 2 commits into from
Sep 23, 2022

Conversation

nwithan8
Copy link
Member

Description

  • Add upgrade guide for v3->v4

Testing

  • N/A

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team September 22, 2022 21:26
@nwithan8
Copy link
Member Author

Linting fails, requires this PR: #339

Justintime50
Justintime50 previously requested changes Sep 23, 2022
View reviewed changes
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Show resolved Hide resolved
@Justintime50
Copy link
Member

Linter is sad, needs to be rebased.

Justintime50
Justintime50 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-LGTM

@nwithan8 nwithan8 merged commit b0e4377 into v4 Sep 23, 2022
@nwithan8 nwithan8 deleted the upgrade_guide branch September 23, 2022 20:44
@Justintime50 Justintime50 mentioned this pull request Oct 3, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @Justintime50 @jchen293