Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port missing features #327

Merged
merged 10 commits into from
Sep 19, 2022
Merged

Port missing features #327

merged 10 commits into from
Sep 19, 2022

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Sep 16, 2022

Description

  • All features introduced into master since the rewrite process began have been ported into the rewrite.
  • Improvements to client handoff
    • All EasyPostObject objects and sub-objects will be handed the client used to create them (i.e. when creating a Shipment, not only will the Shipment object have the client used to create it, assigned to it, but the sub-objects of that Shipment (ToAddress, FromAddress, Parcel, etc.) will also have the client assigned to them)
  • Client equality is now determined by the client configuration (if two clients have the same API key and API base, they are equivalent)
  • Beta models/services have been removed from beta folders/namespaces
    • Access to these beta features is dictated by their presence in the beta client, and beta endpoint usage is dictated by the API version override parameter in functions.
    • The namespaces/folders, while adding some organization, are ultimately unnecessary, and cause more refactoring needs when moving a feature from beta to GA

Testing

  • All unit tests pass
  • New unit tests have been added and recorded as needed
  • EndShipper unit tests have been re-recorded for GA (no beta unit tests exist for EndShipper)

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- EndShipper all returns collection rather than list
…that can have a client)

- Improve client equality (two clients are equal if their configurations are equal -> two configurations are equal if their API keys, API bases and custom HTTP clients (if present) are equal)
- New unit test to verify that client is being passed properly
- Port improvements to test report script
@nwithan8 nwithan8 requested a review from a team September 16, 2022 20:15
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked the list and this seems to be everything. Please double check yourself to ensure we haven't missed something.

@nwithan8
Copy link
Member Author

I double checked the list and this seems to be everything. Please double check yourself to ensure we haven't missed something.

I have manually checked every PR made to master in the past two months, and it does seem like we have gotten everything.

@nwithan8 nwithan8 merged commit 6153026 into v4 Sep 19, 2022
@nwithan8 nwithan8 deleted the ports branch September 19, 2022 17:10
@nwithan8 nwithan8 restored the ports branch September 19, 2022 17:11
@nwithan8 nwithan8 deleted the ports branch September 19, 2022 17:11
@Justintime50 Justintime50 mentioned this pull request Oct 3, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants