Fix naming scheme, property nullabilities #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting into draft mode until Pickup buy API issues have been resolved. |
- Some properties had to be renamed to avoid conflicts (look for "// X is the enclosing class name" comments) - Removed Verify/VerifyStrict parameters from Address (naming conflict, parameters aren't actually part of the Address object, they're API call params) - All properties are nullable (most if not all will NOT be null, but since they could be, to avoid compile complaints) - Addressed some IDE suggestions/warnings
- Pickup buy is failing currently (API 500 error)
|
Pickup test has been disabled for the time being. Re-enable ASAP. |
Justintime50
reviewed
Sep 9, 2022
There was a problem hiding this comment.
- I don't like the renamed property changes, but it is what it is. Please call them out in the CHANGELOG.
- Now that things are marked nullable, we need to remove the compile warning check we ignored so that anything added in the future will throw errors appropriately if we forgot. I'm not seeing that here
Comment on lines
+18
to
+19
| <PackageReference Include="EasyVCR" Version="[0.4.0, 1.0.0)" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="[17.3.0, 18.0.0)" /> |
There was a problem hiding this comment.
I'm tired of seeing these changes in PRs. Can we enforce SOME kind of style for these? They are always getting bumped one way then bumped back the very next commit.
There was a problem hiding this comment.
I'll try to narrow down on what exactly does this
- Remove old nullability warning suppressions from main namespace (add to EasyPost.Tests) - New nullability helper functions to check for nullable elements (see ShipmentService.CreateReturn)
Justintime50
requested changes
Sep 9, 2022
- Remove now-unneeded nullability utilities - Update CHANGELOG.md with info about nullable properties
Justintime50
approved these changes
Sep 9, 2022
- Suppress some IDE suggestions (I know better than the IDE sometimes)
jchen293
approved these changes
Sep 13, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Request
easypost-csharp/EasyPost/Models/API/Shipment.cs
Line 118 in 5e539f2
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.