Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for --type support of ee site command #104

Merged
merged 41 commits into from
Aug 30, 2018
+2,953 −313
Merged

Refactor for --type support of ee site command #104

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
9030635
Move AcmePhp from core to site-command
mrrobot47 Aug 28, 2018
9dcdd84
Move site related files from core to site-command
mrrobot47 Aug 28, 2018
ab8c4d0
Update composer dependencies
mrrobot47 Aug 28, 2018
74dbc3a
Update namespaces and change Site_Command to HTML site-type
mrrobot47 Aug 28, 2018
106134c
Use constants where applicable
mrrobot47 Aug 28, 2018
7dbb02f
Add site-type routing in site-command
mrrobot47 Aug 28, 2018
2535117
add help hook for site-type and register html site-type
mrrobot47 Aug 28, 2018
a2cbf6a
Move template from core to site-command
mrrobot47 Aug 28, 2018
b947d24
Update template path
mrrobot47 Aug 28, 2018
81e5159
Update namespace and filenames
mrrobot47 Aug 28, 2018
1cf1d40
Update namespace and filenames
mrrobot47 Aug 28, 2018
b8ff0f0
Load site utility function file
mrrobot47 Aug 28, 2018
2976ebe
Add type namespace in shutdownhandler and letsencrypt class
mrrobot47 Aug 28, 2018
a7382df
Remove unnecessary namespace
mrrobot47 Aug 28, 2018
da2cb12
Add type namespace to Abstract class
mrrobot47 Aug 28, 2018
ebd3eff
Add type namespace to letsencrypt class
mrrobot47 Aug 28, 2018
0178748
Update EE usage to \EE acc to new namespace
mrrobot47 Aug 28, 2018
a8af7f1
Update getting of args in help and set default type
mrrobot47 Aug 28, 2018
5df0eaf
Update EE usage to \EE for letsencrypt class
mrrobot47 Aug 28, 2018
000c413
Update execeptions according to namespace changes
mrrobot47 Aug 28, 2018
a7f5d88
Merge branch 'develop' into refactor-for-type
mrrobot47 Aug 29, 2018
c9590a5
Move hooks to helper
mrrobot47 Aug 29, 2018
f5d6cce
Reorganize files to helper and site-type folders
mrrobot47 Aug 29, 2018
eaefba4
Move use statement to hooks file
mrrobot47 Aug 29, 2018
828e731
Update doc comment
mrrobot47 Aug 29, 2018
ed5c6e0
Update warning message
mrrobot47 Aug 29, 2018
eb2e1e4
Update sprintf
mrrobot47 Aug 29, 2018
69b6976
Remove TODO from code to track in seperate issue
mrrobot47 Aug 29, 2018
4d9dc92
Update hook name and doc comment
mrrobot47 Aug 29, 2018
4f66fc2
Add early return in help hook
mrrobot47 Aug 29, 2018
75e55f7
Rename html class file
mrrobot47 Aug 29, 2018
6dd18f8
Update help info in doc block
mrrobot47 Aug 29, 2018
18c462f
Update path for require
mrrobot47 Aug 29, 2018
077316c
Move shutdownfunction and common rollback to abstract class
mrrobot47 Aug 29, 2018
b5c167d
Move file loading to composer
mrrobot47 Aug 29, 2018
e408a92
Update loading sequence
mrrobot47 Aug 29, 2018
72444d8
Change hook addition
mrrobot47 Aug 29, 2018
eb15ce5
Remove test trigger of error
mrrobot47 Aug 29, 2018
a313af6
Update hooks file to add hooks
mrrobot47 Aug 29, 2018
482b4f8
Update sprintf usage
mrrobot47 Aug 30, 2018
cd38bc7
Update function name
mrrobot47 Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@
"branch-alias": {
"dev-master": "1.x-dev"
},
"bundled": true,
"commands": [
"site",
"site create",
"site list",
"site delete"
]
"bundled": true
},
"require": {
"acmephp/core": "dev-master",
"ext-openssl": "*",
"guzzlehttp/guzzle": "^6.0",
"league/flysystem": "^1.0.19",
"symfony/serializer": "^3.0",
"webmozart/assert": "^1.0"
}
}
11 changes: 10 additions & 1 deletion site-command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?php

if ( ! defined ( 'SITE_TEMPLATE_ROOT' ) ) {
use EE\Dispatcher\CommandFactory;

if ( ! defined( 'SITE_TEMPLATE_ROOT' ) ) {
define( 'SITE_TEMPLATE_ROOT', __DIR__ . '/templates' );
}

Expand All @@ -13,4 +15,11 @@
require_once $autoload;
}

// Load utility functions.
require_once 'src/helper/site-utils.php';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add file using abs path.
Use DIR . '/src/helper/site-utills.php';
Do same for other places also.


// Load hooks.
require_once 'src/helper/hooks.php';

EE::add_command( 'site', 'Site_Command' );
Site_Command::add_site_type( 'html', 'EE\Site\Type\HTML' );
Loading