This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Many improvements and fixes #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaming32
changed the title
Gaming32
changed the title
Gaming32
changed the title
|
Ok, this is just a general improvement and bug fix PR now. For example, you couldn't force the server version since 1.19.3, and now I fixed that. |
Earthcomputer
pushed a commit
that referenced
this pull request
Jan 15, 2023
|
Manually merged with significant changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
ConnectionModeto be something registerable instead of being a big enum. I did try to retain binary compatibility. This was done so that I could register new versions into multiconnect in order to support ViaLegacy with an extension. To contribute to that end, I also madeViaMulticonnectTranslator#apiprotectedso I don't need to use a Mixin in order to set it.