Update mpas-ocean version #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an update of MPAS-Seaice necessary to keep up with
the changes to mpas-framework that are part of the update
of MPAS-Ocean to a new version for GPU acceleration.
dazlich
requested review from
sherimickelson,
supreethms1809,
gdicker1 and
areanddee
|
Also, I have merge issues to deal with with EarthWorksOrg /mpas-ocean PR #15 |
|
One note on this seaice port - it required a shared constant that is in the E3SM shr_const_mod.F90 but not in the CESM/EarthWorks version. I have added the declaration for it: in mpas-seaice/src/column/constants/cesm/ice_constants_colpkg.F90. Do we want this declaration to get into the share/src/shr_const_mod.F90 file? |
This was referenced Oct 11, 2024
That would be reasonable, but I have two thoughts that conflict and make me think that the code in this PR is good enough.
I think we could "earmark" this in an Issue and delay the issue of adding this to CESM_share. |
|
Agreed
Sent from my iPhone
On Oct 15, 2024, at 4:39 PM, G. Dylan Dickerson ***@***.***> wrote:
** Caution: EXTERNAL Sender **
Do we want this declaration to get into the share/src/shr_const_mod.F90 file?
That would be reasonable, but I have two thoughts that conflict and make me think that the code in this PR is good enough.
* The easiest thing would be to fork the CESM_share repo under EarthWorksOrg and add this change, but we're trying to be closer in synch with CESM. So I don't think another fork would be good right now.
* I also don't think it would be worthwhile to slow this PR down while we wait for a PR to the ESCOMP/CESM_share repo to be accepted. (Admittedly, this is a super small change that could be quick).
I think we could "earmark" this in an Issue and delay the issue of adding this to CESM_share.
—
Reply to this email directly, view it on GitHub<#17 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWCFP4UI6FZO26QJUU3Z3WKR3AVCNFSM6AAAAABPXCAURSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJVGI4TANJWG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Two entries in the prescribed_ice section were accidentally deleted and that broke the prescribed mode for seaice. They have been restored.
gdicker1
approved these changes
Oct 18, 2024
gdicker1
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mpas-ocean component is updated to a new version: branch 'vanroekel/ocean/update-nonhydro-2-15-2023' of https://github.com/vanroekel/E3SM . This new version permits GPU acceleration to be implemented to the ocean, and features a non-hydrostatic treatment of the vertical coordinate in the split-implicit time integration scheme.
The changes in mpas-seaice involve importing the entire new version. This was the simplest way to deal with the associated changed in mpas-framework.
This is part of a package of PRs for branches named update/ocean:
EarthWorksOrg /mpas-ocean PR #15
EarthWorksOrg /mpas-seaice PR #17
EarthWorksOrg /mpas-framework PR #10
EarthWorksOrg /CMEPS PR #12
EarthWorksOrg/EarthWorks PR #75 (incorporates above)
To clone this version of Earthworks use the update/ocean branch.