Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 compsets that use cam_dev physics #51

Merged
merged 4 commits into from
May 31, 2024

Conversation

gdicker1
Copy link
Contributor

F2000devEW copies F2000dev from CAM, but uses the mpas-seaice prescribed mode instead of CICE. CHAOS2000dev uses the cam_dev physics instead of CAM6. These compsets should allow GPU runs of MPAS-A dycore, PUMAS, and RRTMPG.

@gdicker1 gdicker1 self-assigned this May 30, 2024
@gdicker1 gdicker1 added enhancement New feature or request external Has to do with externals EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream labels May 30, 2024
@gdicker1
Copy link
Contributor Author

This PR depends on the CAM changes in #50 and in EWOrg/CAM #18.

Copy link
Contributor

@dazlich dazlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice

@gdicker1
Copy link
Contributor Author

@dazlich, actually a quick question: do you (or anyone) know why we are using CISM2%NO_EVOLVE in F2000climoEW? And would there be any issues changing to SGLC?

The F2000climo in CAM uses SGLC and the F2000devEW entry I added also uses SGLC.

@dazlich
Copy link
Contributor

dazlich commented May 30, 2024 via email

@gdicker1
Copy link
Contributor Author

I don’t know, probably a bad copy and paste on my part.

Please, go ahead and make the entries consistent.

Thank ye much! Addressed in 30ab939

gdicker1 added 3 commits May 30, 2024 14:07
F2000devEW copies F2000dev from CAM, but uses the mpas-seaice prescribed
mode instead of CICE. CHAOS2000dev uses the cam_dev physics instead of
CAM6. These compsets should allow CPU+GPU runs of MPAS-A dycore, PUMAS,
and RRTMPG.
To match F2000climo from CAM and the new F2000devEW compset,
F2000climoEW should use SGLC instead of CISM2%NO_EVOLVE.
@gdicker1 gdicker1 force-pushed the feature/cam_dev_compsets branch from 30ab939 to 314270f Compare May 30, 2024 20:09
@gdicker1
Copy link
Contributor Author

Force push was to incorporate changes from PR #50 in this branch.

@gdicker1 gdicker1 marked this pull request as ready for review May 30, 2024 20:23
@gdicker1 gdicker1 force-pushed the feature/cam_dev_compsets branch from 314270f to cf1238e Compare May 31, 2024 15:58
@gdicker1
Copy link
Contributor Author

Push from 314270f to cf1238e was to correct the cam tag, I used cam-ew2.1.004 instead of the tag that incorporated Supreeth's changes (cam-ew2.1.005).

@gdicker1 gdicker1 merged commit 7ae37fc into EarthWorksOrg:develop May 31, 2024
gdicker1 added a commit to gdicker1/EarthWorks that referenced this pull request Aug 22, 2024
8f78adc Bump to 0.8.4
1ee334a Merge pull request EarthWorksOrg#58 from ESMCI/fix/hashid
e705f72 fix hash id and tag parsing
36b4b92 Bump to 0.8.3
654d233 Merge pull request EarthWorksOrg#57 from ESMCI/fix_test_output
0a4ea71 update the way tags are identified
6ee78d6 correct count of test fails
75a0337 Bump to 0.8.2
7136066 Merge pull request EarthWorksOrg#54 from ESMCI/fix/tag-not-found
a90de4f update to fetch tag first
a6e43fc Bump to 0.8.1
229ba03 Merge pull request EarthWorksOrg#53 from ESMCI/fix/ssh_access
e9cd2be better fix for issue with ssh access
c624b61 Bump to 0.8.0
6ccf617 Merge pull request EarthWorksOrg#51 from ESMCI/fix/recursive
53fce57 no need to make submodule objects persist
dae1c82 now working with issue EarthWorksOrg#50
ded91fd all tests passing, issue EarthWorksOrg#50 fixed
62a338b all pytests now passing
143abac tests a-d all pass
2b021fd add documentation to submodule.py
72211d2 add the new submodule class
82dd7a4 test_b_update now working
a7d8b4e all pytests passing
5322019 Bump to 0.7.9
1f07cb6 Merge pull request EarthWorksOrg#49 from ESMCI/fix/fxDONOTUSEurl
31ce71b use poetry update to update poetry.lock file
46043f0 add code of conduct (issue EarthWorksOrg#35)
0c3d683 dependabot changes and issue EarthWorksOrg#48

git-subtree-dir: .lib/git-fleximod
git-subtree-split: 8f78adcb0386cf496de377b9a92705e44f3f9a37
gdicker1 added a commit to gdicker1/EarthWorks that referenced this pull request Aug 28, 2024
8f78adc Bump to 0.8.4
1ee334a Merge pull request EarthWorksOrg#58 from ESMCI/fix/hashid
e705f72 fix hash id and tag parsing
36b4b92 Bump to 0.8.3
654d233 Merge pull request EarthWorksOrg#57 from ESMCI/fix_test_output
0a4ea71 update the way tags are identified
6ee78d6 correct count of test fails
75a0337 Bump to 0.8.2
7136066 Merge pull request EarthWorksOrg#54 from ESMCI/fix/tag-not-found
a90de4f update to fetch tag first
a6e43fc Bump to 0.8.1
229ba03 Merge pull request EarthWorksOrg#53 from ESMCI/fix/ssh_access
e9cd2be better fix for issue with ssh access
c624b61 Bump to 0.8.0
6ccf617 Merge pull request EarthWorksOrg#51 from ESMCI/fix/recursive
53fce57 no need to make submodule objects persist
dae1c82 now working with issue EarthWorksOrg#50
ded91fd all tests passing, issue EarthWorksOrg#50 fixed
62a338b all pytests now passing
143abac tests a-d all pass
2b021fd add documentation to submodule.py
72211d2 add the new submodule class
82dd7a4 test_b_update now working
a7d8b4e all pytests passing
5322019 Bump to 0.7.9
1f07cb6 Merge pull request EarthWorksOrg#49 from ESMCI/fix/fxDONOTUSEurl
31ce71b use poetry update to update poetry.lock file
46043f0 add code of conduct (issue EarthWorksOrg#35)
0c3d683 dependabot changes and issue EarthWorksOrg#48

git-subtree-dir: .lib/git-fleximod
git-subtree-split: 8f78adcb0386cf496de377b9a92705e44f3f9a37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream external Has to do with externals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants