-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add superfast connectors as an extension #36
Conversation
I have completed the coding and testing. The connector documentation can be found here: earthsci.dev/tutorials/example.md |
Gov4Git noticesOn Notice
|
The tests run successfully locally with Julia 1.10. But it only passed the Julia 1.9 check. I will try to resolve this problem. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
============================================
+ Coverage 79.09% 100.00% +20.90%
============================================
Files 4 5 +1
Lines 177 181 +4
============================================
+ Hits 140 181 +41
+ Misses 37 0 -37 ☔ View full report in Codecov by Sentry. |
It looks like the issues with v1.10 are caused by the @register issue you've fixed elsewhere, and the units issue should be fixed when we update to MTK v9: https://github.com/SciML/ModelingToolkit.jl/blob/master/NEWS.md |
Gov4Git noticesOn Notice
|
Fixes #22
Captures #22