Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add superfast connectors as an extension #36

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

jialinl6
Copy link
Contributor

@jialinl6 jialinl6 commented Mar 8, 2024

Fixes #22

Captures #22

@jialinl6
Copy link
Contributor Author

jialinl6 commented Mar 8, 2024

I have completed the coding and testing. The connector documentation can be found here: earthsci.dev/tutorials/example.md

@ctessum
Copy link
Member

ctessum commented Mar 8, 2024

This project is governed with Gov4Git. Gov4Git notices

On Friday, 08-Mar-24 19:37:43 UTC by Gov4Git dev

Notice qx4o3o

Started managing this PR as Gov4Git proposal 36 with initial approval score of 0.000000.

This project is managed by Gov4Git, a decentralized governance system for collaborative git projects.
To participate in governance, install the Gov4Git desktop app.

@jialinl6
Copy link
Contributor Author

jialinl6 commented Mar 8, 2024

The tests run successfully locally with Julia 1.10. But it only passed the Julia 1.9 check. I will try to resolve this problem.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9fc542) to head (6233dde).

Additional details and impacted files
@@             Coverage Diff              @@
##             main       #36       +/-   ##
============================================
+ Coverage   79.09%   100.00%   +20.90%     
============================================
  Files           4         5        +1     
  Lines         177       181        +4     
============================================
+ Hits          140       181       +41     
+ Misses         37         0       -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctessum
Copy link
Member

ctessum commented Mar 11, 2024

It looks like the issues with v1.10 are caused by the @register issue you've fixed elsewhere, and the units issue should be fixed when we update to MTK v9: https://github.com/SciML/ModelingToolkit.jl/blob/master/NEWS.md

@ctessum
Copy link
Member

ctessum commented Mar 11, 2024

This project is governed with Gov4Git. Gov4Git notices

On Monday, 11-Mar-24 15:36:06 UTC by Gov4Git dev

Notice d24cjx

This PR's approval score is now 3.000000.
The cost of review is 9.000000.
The projected bounty is now 0.000000.

Notice 623oqg

The set of eligible issues claimed by this PR is empty.

@ctessum ctessum merged commit 226004d into EarthSciML:main Mar 11, 2024
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
@ctessum
Copy link
Member

ctessum commented Mar 11, 2024

This project is governed with Gov4Git. Gov4Git notices

On Monday, 11-Mar-24 15:44:01 UTC by Gov4Git dev

Notice vq2plo

This PR, managed as Gov4Git proposal 36, has been accepted 🎉

The PR approval score was 3.000000.

No issues were claimed by this PR.

PR reviewers were rewarded as follows:

  • Reviewer @ctessum was rewarded 9.000000 credits

The cost of review of this PR was 9.000000.

PR approval tally by reviewer was:

  • Reviewer @ctessum contributed 3.000000 votes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SuperFast connectors as an extension.
2 participants