Try to fix issues found on website generated by Documenter.jl #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 79.09% 79.09%
=======================================
Files 4 4
Lines 177 177
=======================================
Hits 140 140
Misses 37 37 ☔ View full report in Codecov by Sentry. |
ctessum
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
I just reviewed the website generated by Documenter.jl (https://deposition.earthsci.dev/dev/dry_deposition/) and noticed two issues. The first is a subscript problem where SO₂ renders correctly in Markdown but not on the website (SO2). The second issue is that the plots are not being automatically generated. Perhaps I should remove julia from ```julia @example 1 to resolve this.
Would you mind merging the changes into the EarthSciML/AtmosphericDeposition.jl repository to see if they work?