Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value issue fixed. vct changed to type #52

Merged
merged 1 commit into from
May 21, 2024
Merged

Value issue fixed. vct changed to type #52

merged 1 commit into from
May 21, 2024

Conversation

andreasabr
Copy link
Collaborator

There was an issue with the issuer metadata. In the RFC001 we used two time the key name"vct" for the verifiable credential type which does not exist in the OIDC4CI standard. The correct key name is "type". I changed it.

@andreasabr andreasabr added bug Something isn't working EWC RFC 001 Issue Verifiable Credential labels Apr 26, 2024
@andreasabr andreasabr requested a review from lalc April 26, 2024 08:00
Copy link
Collaborator

@ntsbs ntsbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was based on the credential definition for SD-JWT VC in HAIP:
https://openid.github.io/oid4vc-haip-sd-jwt-vc/openid4vc-high-assurance-interoperability-profile-sd-jwt-vc-wg-draft.html#section-7.2.2-3

OID4VCI draft 12 has no profile defined for SD-JWT VC

OID4VCI draft 13 (ID.1) defines vct on a higher level

I would keep the current version of HAIP and adopt the changes of draft 13 with the move to ID.1

@andreasabr
Copy link
Collaborator Author

That is correct @ntsbs. Nevertheless, RFC001 refers to draft 12, and this draft does not mention "vct". For the first piloting, we decided to not use SD-JWT and focus on our RFC001, therefore, it makes more sense to update the RFC001 after the first piloting. @lalc @georgepadayatti @endimion please add your comments

@lalc
Copy link
Contributor

lalc commented Apr 26, 2024

That is correct @ntsbs. Nevertheless, RFC001 refers to draft 12, and this draft does not mention "vct". For the first piloting, we decided to not use SD-JWT and focus on our RFC001, therefore, it makes more sense to update the RFC001 after the first piloting. @lalc @georgepadayatti @endimion please add your comments

Yes I agree.

@ntsbs
Copy link
Collaborator

ntsbs commented Apr 26, 2024

For the first piloting, we decided to not use SD-JWT and focus on our RFC001

If you are not using SD-JWT then why would you change the SD-JWT example? The example that you changed is the profile definition for SD-JWT

@endimion
Copy link
Collaborator

On the ITB and issuer I will update the definition as "type" instead of vct for non sd-jwt cases. In sd-jwt cases this will remain as vct.

@andreasabr
Copy link
Collaborator Author

If the RFC refers to draft 12 (as previously agreed on), we have to change the value to "type", otherwise it breaks the interoperability and does not comply anymore with the standard. Otherwise, we have to refer to a newer version of the draft e.g. v13. This adoption is considered anyway, but not directly before the piloting is happening.

@lalc
Copy link
Contributor

lalc commented Apr 26, 2024

If the RFC refers to draft 12 (as previously agreed on), we have to change the value to "type", otherwise it breaks the interoperability and does not comply anymore with the standard. Otherwise, we have to refer to a newer version of the draft e.g. v13. This adoption is considered anyway, but not directly before the piloting is happening.

Should we move to version 13, make an interim EWC RFC version 1.1 release, and not wait for June? The impacts seem relatively straightforward. The justification is also that draft 13 is the approved version now. Please vote up/down so we can decide.

@lalc
Copy link
Contributor

lalc commented May 21, 2024

I will merge to main for now, and let's aim to move to draft-13 on 01-June. Please use issue #47 to decide on the precise switching date.

@lalc lalc merged commit 5665c32 into main May 21, 2024
@lalc lalc deleted the issuer-metadata-issue branch May 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EWC RFC 001 Issue Verifiable Credential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants