Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential Issuer Metadata credentials_supported field must be an object #9

Closed
ntsbs opened this issue Feb 8, 2024 · 1 comment
Closed
Assignees
Labels
EWC RFC 001 Issue Verifiable Credential

Comments

@ntsbs
Copy link
Collaborator

ntsbs commented Feb 8, 2024

The credential issuer metadata field credentials_supported received in RFC001 3.4 Discover response must not be an array, but an object according to OID4VCI draft 12 Section 10.2.3

Current:

"credentials_supported": [
    {
      "format": "jwt_vc",
      "types": [
        "VerifiableCredential",
        "VerifiableAttestation",
        "VerifiablePortableDocumentA1"
      ],
      "trust_framework": {
        "name": "ebsi",
        "type": "Accreditation",
        "uri": "TIR link towards accreditation"
      },
      "display": [
        {
          "name": "Portable Document A1",
          "locale": "en-GB"
        }
      ]
    }
  ]

Expected:

"credentials_supported": {
        "VerifiablePortableDocumentA1": {
            "format": "vc+sd-jwt",
           ...
        },
       "VerifiablePortableDocumentA2": {
            "format": "vc+sd-jwt",
           ...
        }
}
@georgepadayatti georgepadayatti self-assigned this Feb 8, 2024
@georgepadayatti georgepadayatti added the EWC RFC 001 Issue Verifiable Credential label Feb 8, 2024
@lalc
Copy link
Contributor

lalc commented Feb 12, 2024

This change is accepted. The supported credential formats are documented here: https://github.com/EWC-consortium/eudi-wallet-rfcs/blob/main/ewc-supported-formats.csv

@lalc lalc closed this as completed in 7ab4e48 Feb 12, 2024
lalc added a commit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EWC RFC 001 Issue Verifiable Credential
Projects
None yet
Development

No branches or pull requests

3 participants