Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential request format and types are not following the OID4VCI draft 12 #10

Closed
ntsbs opened this issue Feb 8, 2024 · 0 comments
Closed
Assignees
Labels
EWC RFC 001 Issue Verifiable Credential

Comments

@ntsbs
Copy link
Collaborator

ntsbs commented Feb 8, 2024

The credential request in RFC001 3.9 Credential request is not adopting the credential request for jwt_vc_json in OID4VCI draft 12 Appendix E.1.1.5

The current version is using a types field which is not defined in the spec and it is using the wrong format identifier jwt_vc should be jwt_vc_json.

Current:

{
  "format": "jwt_vc",
  "proof": {
    "jwt": "eyJraWQiOiJkaWQ6a2...su7UFClz9NQnw",
    "proof_type": "jwt"
  },
  "types": [
    "VerifiableCredential",
    "VerifiableAttestation",
    "VerifiablePortableDocumentA1"
  ]
}

Expected:

{
   "format": "jwt_vc_json",
   "credential_definition": {
      "type": [
         "VerifiableCredential",
         "UniversityDegreeCredential"
      ],
      "credentialSubject": {
         "given_name": {},
         "family_name": {},
         "degree": {}
      }
   },
   "proof": {
      "proof_type": "jwt",
      "jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTplYmZlYjFmNzEyZWJjNmYxYzI3NmUxMmVjMjEva2V5cy8
      xIiwiYWxnIjoiRVMyNTYiLCJ0eXAiOiJKV1QifQ.eyJpc3MiOiJzNkJoZFJrcXQzIiwiYXVkIjoiaHR
      0cHM6Ly9zZXJ2ZXIuZXhhbXBsZS5jb20iLCJpYXQiOiIyMDE4LTA5LTE0VDIxOjE5OjEwWiIsIm5vbm
      NlIjoidFppZ25zbkZicCJ9.ewdkIkPV50iOeBUqMXCC_aZKPxgihac0aW9EkL1nOzM"
   }
}
@georgepadayatti georgepadayatti added the EWC RFC 001 Issue Verifiable Credential label Feb 8, 2024
@lalc lalc closed this as completed in 5d8f630 Feb 12, 2024
lalc added a commit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EWC RFC 001 Issue Verifiable Credential
Projects
None yet
Development

No branches or pull requests

3 participants