Workaround for a bug affecting CMake < 0.30.3 and CPM >= 0.40.1 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpm-cmake/CPM.cmake#603 Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
When a ${PACKAGE}_SOURCE_DIR is set before project() is called
projects where the name and project-dir-name differ,
like "gtest" for "googletest" in everest-core seem to have the wrong
${PACKAGE}_SOURCE_DIR set after the project() call
Signed-off-by: Kai-Uwe Hermann <[email protected]>
florinmihut
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in CMake versions < 0.30.3 that gets triggered by CPM >= 0.40.1 ( see cpm-cmake/CPM.cmake#603 ). This PR ensures that the new code path is only used for CMake versions that have the fix