fix build and test failures on arm64 linux platform #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are few build and test failures on arm64 platform with "narrowing conversion" errors. This is due to the char datatype implementation differences between different platforms and gcc versions. This commit replaces the char datatype with the explicit datatype that works across all the platforms.
snadampal
force-pushed
the
aarch64_fix
branch
from
4a630e9
to
98bcb6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are few build and test failures on arm64 platform with "narrowing conversion" due to char implementation differences between differnet platforms and gcc versions. This patch is to replace char with explicit datatype that works across all the platforms.