Reduce compiler warning when using ETL_DECLARE_DEBUG_COUNT.
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced:
(ETL_DECLARE_DEBUG_COUNT\s*?);+
with
\1
In order to avoid warning as such
Warning[Pe381]: extra ";" ignored etl\include\etl\private\vector_base.h 171
When
!defined(ETL_DEBUG_COUNT)
Partially reverts c92ab94.
|
View changes with SemanticDiff |
|
I fixed this in #749, but it looks like I forgot to merge the changes in the last release! |
|
I can confirm, this issue is resolved. A different solution has been applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced:
with
In order to avoid warning as such
When
⚠ Partially reverts c92ab94.
For
ETL_DECLARE_DEBUG_COUNTit can be assumed, that it will not be part of an expression.For the other
ETL_\w*_DEBUG_COUNTthis can not be assumend.