Fixed Number.k() bug #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the result of Number.k() was a one-item array, that one item was a Number object instead of an ordinary number. This breaks code that checks for an item's existence in the array. For example, "2k ø2", which checks if the number 2 exists in the array of factors of 2, returns false when it should return true. Example in Chrome dev console: http://i.imgur.com/4NawhOk.png This was fixed similarly to how I see you handling some other Number functions: by casting the Number object to an ordinary number by using "+this".
|
Thanks! I realized at some point in the past that you have to be really careful to cast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the result of
Number.k()was a one-item array, that one item was aNumberobject instead of an ordinary number. This breaks code that checks for an item's existence in the array. For example,2k ø2, which checks if the number2exists in the array of factors of2, returns false when it should return true.Example in Chrome dev console
This was fixed similarly to how I see you handling some other Number functions: by casting the Number object to an ordinary number by using
+this.