Fix: Skip the www removal when the host does not start with www #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ex: https://www.github.com/ → github.com https://test.env.www.github.com/ → test.env.www.github.com
YoeriW
added a commit
to YoeriW/Edit-This-Cookie
that referenced
this pull request
Dec 15, 2024
…nifest V3 chore: update and support for chrome manifest version 3 ETCExtensions#373 opened on Aug 31 by cldevdad 2 All the 10 other PR since 2018 + one fix from me ETCExtensions#344 opened on Dec 19, 2022 by cw2k 1 Make links https ETCExtensions#337 opened on Jul 6, 2022 by AndrewLane Fixed adding a cookie using a form ETCExtensions#333 opened on Apr 10, 2022 by Qliane update no locales ETCExtensions#297 opened on Oct 4, 2020 by steinhaug add cookie paste option: toCurrentTabCookieUrl ETCExtensions#292 opened on Aug 12, 2020 by Akimyou Update cookie_helpers.js ETCExtensions#286 opened on Jul 22, 2020 by SnailDev 1 Fix new Chrome cookie policy. ETCExtensions#278 opened on Mar 29, 2020 by dalejung Fix imports like ".domain.com" when there's no URL ETCExtensions#275 opened on Mar 21, 2020 by geekley 2 export for map ETCExtensions#267 opened on Nov 30, 2019 by GongShengyue Fix: Skip the www removal when the host does not start with www ETCExtensions#254 opened on Aug 19, 2019 by sebui Automatic decoding of URLencoded cookies ETCExtensions#235 opened on Oct 24, 2018 by npicca
YoeriW
added a commit
to YoeriW/Edit-This-Cookie
that referenced
this pull request
Dec 15, 2024
…nifest V3 + replaced deprecated chrome function chore: update and support for chrome manifest version 3 ETCExtensions#373 opened on Aug 31 by cldevdad 2 All the 10 other PR since 2018 + one fix from me ETCExtensions#344 opened on Dec 19, 2022 by cw2k 1 Make links https ETCExtensions#337 opened on Jul 6, 2022 by AndrewLane Fixed adding a cookie using a form ETCExtensions#333 opened on Apr 10, 2022 by Qliane update no locales ETCExtensions#297 opened on Oct 4, 2020 by steinhaug add cookie paste option: toCurrentTabCookieUrl ETCExtensions#292 opened on Aug 12, 2020 by Akimyou Update cookie_helpers.js ETCExtensions#286 opened on Jul 22, 2020 by SnailDev 1 Fix new Chrome cookie policy. ETCExtensions#278 opened on Mar 29, 2020 by dalejung Fix imports like ".domain.com" when there's no URL ETCExtensions#275 opened on Mar 21, 2020 by geekley 2 export for map ETCExtensions#267 opened on Nov 30, 2019 by GongShengyue Fix: Skip the www removal when the host does not start with www ETCExtensions#254 opened on Aug 19, 2019 by sebui Automatic decoding of URLencoded cookies ETCExtensions#235 opened on Oct 24, 2018 by npicca
YoeriW
added a commit
to YoeriW/Edit-This-Cookie
that referenced
this pull request
Dec 15, 2024
…nifest V3 + replaced deprecated chrome function chore: update and support for chrome manifest version 3 ETCExtensions#373 opened on Aug 31 by cldevdad 2 All the 10 other PR since 2018 + one fix from me ETCExtensions#344 opened on Dec 19, 2022 by cw2k 1 Make links https ETCExtensions#337 opened on Jul 6, 2022 by AndrewLane Fixed adding a cookie using a form ETCExtensions#333 opened on Apr 10, 2022 by Qliane update no locales ETCExtensions#297 opened on Oct 4, 2020 by steinhaug add cookie paste option: toCurrentTabCookieUrl ETCExtensions#292 opened on Aug 12, 2020 by Akimyou Update cookie_helpers.js ETCExtensions#286 opened on Jul 22, 2020 by SnailDev 1 Fix new Chrome cookie policy. ETCExtensions#278 opened on Mar 29, 2020 by dalejung Fix imports like ".domain.com" when there's no URL ETCExtensions#275 opened on Mar 21, 2020 by geekley 2 export for map ETCExtensions#267 opened on Nov 30, 2019 by GongShengyue Fix: Skip the www removal when the host does not start with www ETCExtensions#254 opened on Aug 19, 2019 by sebui Automatic decoding of URLencoded cookies ETCExtensions#235 opened on Oct 24, 2018 by npicca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the creation of the cookie is set with the domain name returned by the getHost function.
This function strip the
www.of the domain name, in some cases it does not make sense to remove it.I propose to change the
replacefirst parameter from asubstrto aregexppatternsuch as to replace the
www.only if it's placed at the beginning of the hotsname.Ex:
https://www.github.com/ → github.com
https://test.env.www.github.com/ → test.env.www.github.com