Make XML type-aware and fix all the bugs this exposed. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the entries in enx*.xml files have a <type> that was being ignored. This commit changes that. This should help reduce mistakes on the client side by checking that they are using the right types.
jayeshkrishna
pushed a commit
that referenced
this pull request
Aug 16, 2016
Changes required for nightly cdash to work with new Hobart and Nag 6.1
jedwards4b
pushed a commit
that referenced
this pull request
May 31, 2019
Fix memleak in med_phases_prep_ocn_mod
pesieber
pushed a commit
to pesieber/cime
that referenced
this pull request
Mar 15, 2023
a465b4f add --quiet argument to improve performance b2f3ae8 Merge pull request ESMCI#83 from jedwards4b/jedwards/components_arg 3f4c88f fix comment c1b5b09 remove unneeded logic 4fdf180 one more test f78d60f another test bf52ac6 add a test 91d4851 fix pylint issue 987df5a only use components if populated 98a810d add a components arg to checkout only select components 6923119 Merge pull request ESMCI#90 from ESMCI/issue-86-detached-sync-status b11ad61 Merge branch 'master' into issue-86-detached-sync-status 3b624cf Merge pull request ESMCI#93 from billsacks/work_on_coverage 2562830 Run a single coverage command rather than two separate commands d1de5f8 Return to starting directory after each test 144f7d9 Merge pull request ESMCI#92 from billsacks/point_to_esmci 58b8d3e Point to location of repository 0b46d81 Point to correct location for build/coverage status a385070 fix pylint problems dcf17b6 make style cleanup 92d342c Rewrite _current_ref to use plumbing rather than parsing porcelain ca0a5d3 Rework some git repository functions, and major rework of unit tests 719383e Remove commented-out pdb.set_trace() call 376c780 Bugfix: detect and report 'detached from' correctly 21813e9 Add system test demonstrating failure to detect out of sync status. 1a7c59d Merge documentation update into master. f1e9e99 Merge schema support for git hashes into master. 247fee1 Document return values of checkout.py: main 195c1d0 Implement explicit use of a hash for git repositories. 12dd743 Refactor: schema validation output fdbc720 Bugfix: incorrect order of operations validing user input git-subtree-dir: manage_externals git-subtree-split: a465b4fb740e7895248fab4a302d402ea2ba5cf7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the entries in enx*.xml files have a that was being
ignored. This commit changes that. This should help reduce mistakes
on the client side by checking that they are using the right types.