Mvclmbldtry2 #88
Merged
Mvclmbldtry2 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -166,10 +166,6 @@ def case_build(caseroot, case=None, testmode=False, sharedlib_only=False, model_ | |||
| case = Case() if case is None else case | |||
| testcase = case.get_value("TESTCASE") | |||
| cimeroot = case.get_value("CIMEROOT") | |||
There was a problem hiding this comment.
case_build still takes testmode as an optional argument. Does it still need it?
There was a problem hiding this comment.
I think that it doesn't.
|
Review complete. |
jayeshkrishna
pushed a commit
that referenced
this pull request
Aug 16, 2016
Implementation of PIOc_strerror() and pio_strerror() to get strings associated with error codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mv clm build into build_libraries
prepare to move tests into python by looking for TESTNAME_script and
using the python case.test template if its not found.
Instead of having case.test_build and case.build in the case directory and
throwing an error if the user trys case.build, just replace case.build with case.test_build