Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cprnc bug fix locating matching times when time index does not match #66

Merged
merged 1 commit into from
Feb 21, 2016
Merged

cprnc bug fix locating matching times when time index does not match #66

merged 1 commit into from
Feb 21, 2016

Conversation

mt5555
Copy link
Contributor

@mt5555 mt5555 commented Feb 21, 2016

When indicies are advanced, need to recompute time difference, tdiff,
and dont compute tdiff if time indicies exceed array bounds.

When indicies are advanced, need to recompute time difference, tdiff,
and dont compute tdiff if time indicies exceed array bounds.
jedwards4b added a commit that referenced this pull request Feb 21, 2016
cprnc bug fix locating matching times when time index does not match
@jedwards4b jedwards4b merged commit 2ae93cb into ESMCI:master Feb 21, 2016
jayeshkrishna pushed a commit that referenced this pull request Aug 16, 2016
changing in pio_file.c to support async
jgfouca pushed a commit that referenced this pull request Feb 20, 2019
new field specifications for cesm, nems-orig and nems-frac
new esmFldsExchange that permits cesm, nems-orig and nems-frac coupled modes

This PR contains a complete rewrite of the determination of fields exchanged between components, their mappings and mergings of source field(s) to the destination field. The new file cime_flds/esmFldsExchange.F90 now has two phases -

an advertise phase (called from esm.F90)
an initialize phase (called from med.F90)
The initialize phase contains queries to already created field bundles that introduces new flexibility in supporting multiple coupling modes.

In addition all subroutines required to initialize the fldlistto and fldlistfr data structures are now contained in cime_flds/esmFlds.F90 - and are only compiled with the mediator code - and not the share code. So changing these files will not required the re-compilation of all the component files.

Finally, the dead components have been rewritten to permit the overwrite of fields (such as changing the So_omask to 0). Previously, putting in custom changes in dead_nuopc_mod.F90 was not having any effect - so this fixes a bug).

Apologies for the size of this PR. I will try in the future to make smaller ones.

Test suite: default cmeps system tests - testlist_drv.xml
Test baseline: jan11 from jedwards BASELINES
Test namelist changes:
Test status: bit for bit (except for X compset)

Fixes: fixed X compset share code (no issue was raised for this)
User interface changes?: no
Update gh-pages html (Y/N)?:no
Code review:
pesieber pushed a commit to pesieber/cime that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants