Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected leap year correction logic #4726

Merged
merged 1 commit into from
Dec 30, 2024
Merged

corrected leap year correction logic #4726

merged 1 commit into from
Dec 30, 2024

Conversation

jedwards4b
Copy link
Contributor

This fixes the logic for leap year correction in the case in which the final year is a leap year but the final date is prior to March 1.

Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes

User interface changes?:

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b requested a review from peverwhee December 30, 2024 15:33
@jedwards4b jedwards4b self-assigned this Dec 30, 2024
peverwhee
peverwhee approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jedwards4b ! this fixes my failing test

@jedwards4b jedwards4b merged commit ac8e583 into ESMCI:master Dec 30, 2024
7 checks passed
@jedwards4b jedwards4b deleted the leapyr_correction2 branch December 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peverwhee peverwhee peverwhee approved these changes

Assignees

@jedwards4b jedwards4b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedwards4b @peverwhee