Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the standard_name length restriction for CAM-SIMA #4627

Merged
merged 2 commits into from
May 15, 2024

Conversation

jtruesdal
Copy link
Contributor

@jtruesdal jtruesdal commented May 8, 2024

Remove the standard_name 64 character length restriction and allow strings of 1 or more characters. This corrects a CAM-SIMA error for the new dadadj CCPP routine which contains a namelist entry with a standard name greater than the current 63 character limit. The new pattern match removes a length restriction but is consistent with the Guidelines for Construction of CF Standard Names which is adopted in the CCPP Standard Name Rules (rule 2).

Test suite: Built and ran a CAM-SIMA snapshot test with the new routine and I also ran a create_test case with CAM on izumi.
Test baseline: cime6.0.236_httpsbranch01
Test namelist changes: N/A
Test status: bit for bit

Fixes #4625

User interface changes?:Remove string length restriction for standard_name type.

Update gh-pages html (Y/N)?:N

jtruesdal and others added 2 commits May 6, 2024 18:12
… be much longer than 63 chars. Couldnt find a lenght limit for that field in the docs
@jtruesdal
Copy link
Contributor Author

@jedwards4b What is the procedure for getting this reviewed and merged? I looked at the workflow doc but didn't see any specifics about who to assign ie. who is authorized to merge? Just FYI Steve G. did comment on the fix via the associated issue. Do I pick reviewers?

@jedwards4b jedwards4b merged commit 735f5f3 into ESMCI:master May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase standard_name length in entry_id_pg.xsd
2 participants