Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MPASO_USE_PETSC #4464

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Add support for MPASO_USE_PETSC #4464

merged 2 commits into from
Jul 24, 2023

Conversation

jgfouca
Copy link
Contributor

@jgfouca jgfouca commented Jul 24, 2023

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

@jgfouca jgfouca added the Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM label Jul 24, 2023
@jgfouca jgfouca requested review from jasonb5 and jonbob July 24, 2023 16:04
@jgfouca jgfouca self-assigned this Jul 24, 2023
Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfouca jgfouca merged commit 883edea into master Jul 24, 2023
@jgfouca jgfouca deleted the jgfouca/mpas_ocn_petsc branch July 24, 2023 18:30
@rljacob rljacob requested a review from bishtgautam July 24, 2023 19:46
@rljacob
Copy link
Member

rljacob commented Jul 24, 2023

@bishtgautam I notice ELM uses "USE_PETSC_LIB" as a cpp in its code. How is that set?

@bishtgautam
Copy link
Contributor

@rljacob Currently, the code to add -DUSE_PETSC_LIB is broken in E3SM for a long time.

@rljacob
Copy link
Member

rljacob commented Jul 24, 2023

Ok. The logic we are going for is to allow a user to specify which components need PETSc. Any combination of on/off should be allowed. If any of them do, add the PETSc library to the linker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants