Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_test: fix compiler inferring #4297

Merged
merged 11 commits into from
Aug 31, 2022

Conversation

jgfouca
Copy link
Contributor

@jgfouca jgfouca commented Aug 31, 2022

If the user does this: create_test SMS.GRID.CASE.mappy_gnu9
... create_test should not assume the compiler is gnu even though
that's the default compiler for mappy. It should behave as if the
user provided --compiler=gnu9 which will allow the test to find
the correct baselines.

Also, mappy testing was in a bad state due to tests not loading the correct E3SM config.py library. This PR fixes that also.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

If the user does this: create_test SMS.GRID.CASE.mappy_gnu9
... create_test should not assume the compiler is gnu even though
that's the default compiler for mappy. It should behave as if the
user provided --compiler=gnu9 which will allow the test to find
the correct baselines.
Was not loading correct config for tests.
@jgfouca jgfouca added the Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM label Aug 31, 2022
@jgfouca jgfouca requested a review from jasonb5 August 31, 2022 17:00
@jgfouca jgfouca self-assigned this Aug 31, 2022
Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfouca jgfouca merged commit a7fa4c0 into master Aug 31, 2022
@jgfouca jgfouca deleted the jgfouca/fix_create_test_compiler_inferring branch August 31, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants