More early resolve issues #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1766,14 +1766,6 @@ | |||
| <desc>Machine name</desc> | |||
| </entry> | |||
|
|
|||
| <entry id="MACHINES_FILE"> | |||
There was a problem hiding this comment.
Not used anyplace as far as i can tell.
| @@ -21,8 +21,8 @@ def expect(condition, error_msg, exc_type=SystemExit): | |||
| """ | |||
| if (not condition): | |||
| # Uncomment these to bring up a debugger when an expect fails | |||
| #import pdb | |||
| #pdb.set_trace() | |||
| import pdb | |||
There was a problem hiding this comment.
You probably didn't intend to push this.
|
I've removed the debug stuff and updated the PR |
| self.machines_dir = os.path.dirname(infile) | ||
|
|
||
| infile = files.get_resolved_value(infile) |
There was a problem hiding this comment.
I don't understand this change. Why is calling get_resolved_value by hand better than resolved=True?
There was a problem hiding this comment.
I want self.machines_dir to have the unresolved value
pesieber
pushed a commit
to pesieber/cime
that referenced
this pull request
Mar 15, 2023
Allow first history tape to have other than one time point per file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove more early resolve issues - these were found by cloning a case from one user to another.
Test suite: scripts_regression_test & create_clone from one user to another
Test baseline:
Test namelist changes:
Test status: bit for bit
Connects to #406
User interface changes?:
Code review: