Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neon datm mode #3850

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions config/cesm/config_grids.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@
<grid name="ocnice" compset="SOCN" >null</grid>
<grid name="rof" compset="SROF" >null</grid>
<grid name="rof" compset="DWAV" >rx1</grid>
<grid name="rof" compset="RTM" >r05</grid>
<grid name="rof" compset="RTM" >r05</grid>
<grid name="rof" compset="MOSART" >r05</grid>
<grid name="rof" compset="MIZUROUTE" >HDMA</grid>
<grid name="rof" compset="DROF" >rx1</grid>
<grid name="rof" compset="DROF%CPLHIST">r05</grid>
<grid name="rof" compset="XROF" >r05</grid>
<grid name="glc" compset="SGLC" >null</grid>
<grid name="glc" compset="CISM1" >gland5UM</grid>
<grid name="glc" compset="CISM2" >gland4</grid>
<grid name="glc" compset="SGLC" >null</grid>
<grid name="glc" compset="CISM1" >gland5UM</grid>
<grid name="glc" compset="CISM2" >gland4</grid>
<grid name="glc" compset="XGLC" >gland4</grid>
<grid name="wav" compset="SWAV" >null</grid>
<grid name="wav" compset="DWAV" >ww3a</grid>
<grid name="wav" compset="WW3" >ww3a</grid>
<grid name="wav" compset="SWAV" >null</grid>
<grid name="wav" compset="DWAV" >ww3a</grid>
<grid name="wav" compset="WW3" >ww3a</grid>
<grid name="wav" compset="XWAV" >ww3a</grid>
<grid name="iac" compset="SIAC" >null</grid>
</model_grid_defaults>
Expand Down Expand Up @@ -110,6 +110,12 @@
<grid name="rof">null</grid>
</model_grid>

<model_grid alias="1x1_NEON" compset="DATM.+CLM|DATM.+SLND">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that 1x1_NEON is doing the same thing as CLM_USRDAT_NAME, I'm not sure we need an additional name here that's specific for NEON.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest when using 1x1_ to use 1x1pt_ as used in other places since the default units for grids are in degrees, and the "pt" says that in this case it's "points". So 1x1pt_ is a single point regional grid, while something like 5x5pt_ is a grid that's has 5 points in latitude and also 5 in longitude.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the line below you will see the reason for this name, it supports all of the NEON tower sites:
$DIN_LOC_ROOT/share/domains/single_point/datmdata_NEON/$NEONSITE/domain.lnd.fv
0.9x1.25_gx1v7_$NEONSITE.nc

How about we change the file name to: domain.lnd.1x1pt_$NEONSITE_20210210.nc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since these files shouldn't change (except maybe adding new sites?) I think that solution makes perfect sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one other question I had about this though is I though @mvertens was doing something where single point sites didn't require domain files anymore for NUOPC? I'd have to look at it again to see how that worked though...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I looked at that again, and what she was doing was to eliminate the need for both mesh files AND domain files. But, it's still configured to need domain files.

<grid name="atm">1x1_NEON</grid>
<grid name="lnd">1x1_NEON</grid>
<grid name="rof">null</grid>
</model_grid>

<model_grid alias="1x1_urbanc_alpha" compset="DATM.+CLM|DATM.+SLND">
<grid name="atm">1x1_urbanc_alpha</grid>
<grid name="lnd">1x1_urbanc_alpha</grid>
Expand Down Expand Up @@ -1306,6 +1312,13 @@
<desc>user specified domain - only valid for DATM/CLM compset</desc>
</domain>

<domain name="1x1_NEON">
<nx>1</nx> <ny>1</ny>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here that I ran into with CLM_USRDAT_NAME is that this domain file when updated will change ALL existing simulations being run with it. This is problematic. As such I came to the conclusion a better way to handle it is to have scripts that setup single-point create user-mod directories where the DOMAIN file is set to a particular path that includes a time-stamp in the filename. This way changes to files don't change the results of someone else's existing simulations.

<file grid="atm|lnd">/glade/p/cgd/tss/people/wwieder/inputdata/single_point/datmdata_NEON/$NEONSITE/domain.lnd.fv0.9x1.25_gx1v7_$NEONSITE.nc</file>
<mesh driver="nuopc">create_mesh</mesh>
<desc>1x1 NEON tower site -- only valid for DATM/CLM compset</desc>
</domain>

<domain name="1x1_numaIA">
<nx>1</nx> <ny>1</ny>
<file grid="atm|lnd">$DIN_LOC_ROOT/share/domains/domain.clm/domain.lnd.1x1pt-numaIA_navy.110106.nc</file>
Expand Down
4 changes: 4 additions & 0 deletions config/cesm/config_inputdata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,8 @@
<address>https://svn-ccsm-inputdata.cgd.ucar.edu/trunk/inputdata</address>
</server>

<server>
<comment> NEON Tower data for datm </comment>
<protocol>wget</protocol>
<address>
</inputdata>