Ensure module setup is sourced before list #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rljacob , you're the only one I know who uses a csh-based login shell. Please see if this branch fixes the issue. @jedwards4b I want to be sure you're OK with this change. |
|
You still need to uncomment the code in case_setup.py but I did that and confirmed that this is working (using a tcsh shell where it did not work before). |
|
Works for me too after uncommenting that line. I get a complete software_environment.txt file and no error message. |
|
OK, who wants to click the green button? |
|
I'll merge it. |
rljacob
added a commit
that referenced
this pull request
Aug 10, 2016
Ensure module setup is sourced before list This fixes problems csh users were having when generating software_environment.txt Fixes #372
|
Tested on edison by a csh user (rjacob). software_environment.txt fill was successfully created. |
pesieber
pushed a commit
to pesieber/cime
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test suite: None
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes #372
User interface changes?: No
Code review: @rljacob @jedwards4b